Skip to content

[fix][broker] Fix exclusive producer creation when last shared producer closes #24516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2025
Merged

[fix][broker] Fix exclusive producer creation when last shared producer closes #24516

merged 6 commits into from
Jul 23, 2025

Conversation

@3pacccccc
Copy link
Contributor

@3pacccccc 3pacccccc commented Jul 15, 2025

Motivation

When a producer in WaitForExclusive mode is created while shared producers exist on a topic, it fails to become active even after all shared producers are closed. This occurs because the broker doesn't properly check for waiting exclusive producers when the last shared producer is removed.

Steps to reproduce:

  1. Create a producer with Shared mode
  2. Create a producer with WaitForExclusive mode
  3. Close the first producer
  4. The exclusive producer never gets created

Modifications

  • Modified the condition in handleProducerRemoved() to also check for waiting exclusive producers when the last producer is removed
  • Added test case to verify the fix

Verifying this change

  • Make sure that the change passes the CI checks.

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: 3pacccccc#13

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 15, 2025
@lhotari lhotari added this to the 4.1.0 milestone Jul 16, 2025
lhotari
lhotari approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work @3pacccccc

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (bbc6224) to head (d1645a6).
Report is 1217 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24516      +/-   ##
============================================
+ Coverage     73.57%   74.30%   +0.73%     
+ Complexity    32624    32583      -41     
============================================
  Files          1877     1874       -3     
  Lines        139502   146231    +6729     
  Branches      15299    16772    +1473     
============================================
+ Hits         102638   108662    +6024     
- Misses        28908    28935      +27     
- Partials       7956     8634     +678
Flag Coverage Δ
inttests 26.84% <0.00%> (+2.26%) ⬆️
systests 23.26% <0.00%> (-1.07%) ⬇️
unittests 73.81% <100.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rg/apache/pulsar/broker/service/AbstractTopic.java 88.18% <100.00%> (+0.19%) ⬆️

... and 1107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crossoverJie crossoverJie merged commit efe9dc8 into apache:master Jul 23, 2025
186 of 192 checks passed
lhotari pushed a commit that referenced this pull request Jul 23, 2025
@3pacccccc @crossoverJie @lhotari
[fix][broker] Fix exclusive producer creation when last shared produc…
89a778a 
…er closes (#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
lhotari pushed a commit that referenced this pull request Jul 23, 2025
@3pacccccc @crossoverJie @lhotari
[fix][broker] Fix exclusive producer creation when last shared produc…
efc9fa5 
…er closes (#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
lhotari pushed a commit that referenced this pull request Jul 23, 2025
@3pacccccc @crossoverJie @lhotari
[fix][broker] Fix exclusive producer creation when last shared produc…
102fdb3 
…er closes (#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
@3pacccccc @crossoverJie @priyanshu-ctds
[fix][broker] Fix exclusive producer creation when last shared produc…
43491a0 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
(cherry picked from commit 102fdb3)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
@3pacccccc @crossoverJie @priyanshu-ctds
[fix][broker] Fix exclusive producer creation when last shared produc…
baaf2d6 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
(cherry picked from commit 102fdb3)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
@3pacccccc @crossoverJie @priyanshu-ctds
[fix][broker] Fix exclusive producer creation when last shared produc…
86e23f8 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
(cherry picked from commit efc9fa5)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
@3pacccccc @crossoverJie @srinath-ctds
[fix][broker] Fix exclusive producer creation when last shared produc…
c52a4c0 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
(cherry picked from commit 102fdb3)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
@3pacccccc @crossoverJie @srinath-ctds
[fix][broker] Fix exclusive producer creation when last shared produc…
15c0c94 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
(cherry picked from commit efc9fa5)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
@3pacccccc @crossoverJie @nodece
[fix][broker] Fix exclusive producer creation when last shared produc…
6844d29 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
@3pacccccc @crossoverJie @nodece
[fix][broker] Fix exclusive producer creation when last shared produc…
abb4382 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
(cherry picked from commit efe9dc8)
@3pacccccc 3pacccccc deleted the fixWaitingExclusiveProducers branch August 7, 2025 11:17
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@3pacccccc @crossoverJie @KannarFr
[fix][broker] Fix exclusive producer creation when last shared produc…
0d4b923 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@3pacccccc @crossoverJie @walkinggo
[fix][broker] Fix exclusive producer creation when last shared produc…
d47387f 
…er closes (apache#24516)

Co-authored-by: crossoverJie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@dao-jun dao-jun dao-jun approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

Assignees

@3pacccccc 3pacccccc

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.13 release/3.3.8 release/4.0.6

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@3pacccccc @codecov-commenter @lhotari @dao-jun @poorbarcode @crossoverJie